Set up lint and test

[SimenB]

Not sure what we want here, so I just threw together something that works.

• Do we want flow?
• Do we want babel?

Other:

• Do we want pre-commit hooks for formatting?
• Do we want Travis or Circle?
• Do we want to support node 4?

[orta]

As it's not an externally used lib flow isn't too important to me, and without flow then it doesn't need babel 👍

Do we want pre-commit hooks for formatting?

pre-commit with Prettier is a big 👍 for me

Travis vs Circle

Travis is used on some of the others?

Node 4

I don't have strong opinions - it's still actively supported by node though

[SimenB]

Ok, made those changes.

Tests are failing on node 4 with a really useless error.

One issue with not dropping node 4 is that we won't be able to upgrade jest. Not a huge issue, I guess 🙂

EDIT: Stupid error. Actually running it on node made it obvious, not sure why the error thrown by jest (via new vm.Script()) is so useless.

/Users/simbekkh/repos/eslint-plugin-jest/ugh.js:3
const { RuleTester } = require('eslint');
      ^

SyntaxError: Unexpected token {
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)
    at startup (node.js:140:18)
    at node.js:1043:3

[thymikee]

geez, I love Travis config being so simple compared to Circle 2

[thymikee]

add "bracketSpacing": false maybe?

[SimenB]

do you prefer it? Seems like a fb-ism. Happy to add, of course, I don't really care as long as it's formatted for me :D

[thymikee]

I have no preference, just that the diff would be smaller :D. We can scratch that

[SimenB]

#yolo