/
prefer-comparison-matcher.test.ts
192 lines (186 loc) · 5.87 KB
/
prefer-comparison-matcher.test.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
import { TSESLint } from '@typescript-eslint/utils';
import rule from '../prefer-comparison-matcher';
import { espreeParser } from './test-utils';
const ruleTester = new TSESLint.RuleTester({
parser: espreeParser,
parserOptions: {
ecmaVersion: 2015,
},
});
const generateInvalidCases = (
operator: string,
equalityMatcher: string,
preferredMatcher: string,
preferredMatcherWhenNegated: string,
): Array<TSESLint.InvalidTestCase<'useToBeComparison', never>> => {
return [
{
code: `expect(value ${operator} 1).${equalityMatcher}(true);`,
output: `expect(value).${preferredMatcher}(1);`,
errors: [
{
messageId: 'useToBeComparison',
data: { preferredMatcher },
column: 18 + operator.length,
line: 1,
},
],
},
{
code: `expect(value ${operator} 1)['${equalityMatcher}'](true);`,
output: `expect(value).${preferredMatcher}(1);`,
errors: [
{
messageId: 'useToBeComparison',
data: { preferredMatcher },
column: 18 + operator.length,
line: 1,
},
],
},
{
code: `expect(value ${operator} 1).${equalityMatcher}(false);`,
output: `expect(value).${preferredMatcherWhenNegated}(1);`,
errors: [
{
messageId: 'useToBeComparison',
data: { preferredMatcher: preferredMatcherWhenNegated },
column: 18 + operator.length,
line: 1,
},
],
},
{
code: `expect(value ${operator} 1)['${equalityMatcher}'](false);`,
output: `expect(value).${preferredMatcherWhenNegated}(1);`,
errors: [
{
messageId: 'useToBeComparison',
data: { preferredMatcher: preferredMatcherWhenNegated },
column: 18 + operator.length,
line: 1,
},
],
},
{
code: `expect(value ${operator} 1).not.${equalityMatcher}(true);`,
output: `expect(value).${preferredMatcherWhenNegated}(1);`,
errors: [
{
messageId: 'useToBeComparison',
data: { preferredMatcher: preferredMatcherWhenNegated },
column: 18 + operator.length,
line: 1,
},
],
},
{
code: `expect(value ${operator} 1)['not'].${equalityMatcher}(true);`,
output: `expect(value).${preferredMatcherWhenNegated}(1);`,
errors: [
{
messageId: 'useToBeComparison',
data: { preferredMatcher: preferredMatcherWhenNegated },
column: 18 + operator.length,
line: 1,
},
],
},
{
code: `expect(value ${operator} 1).not.${equalityMatcher}(false);`,
output: `expect(value).${preferredMatcher}(1);`,
errors: [
{
messageId: 'useToBeComparison',
data: { preferredMatcher },
column: 18 + operator.length,
line: 1,
},
],
},
];
};
const generateValidStringLiteralCases = (operator: string, matcher: string) => {
return [
['x', "'y'"],
['x', '`y`'],
['x', '`y${z}`'],
].reduce((cases, [a, b]) => [
...cases,
...[
`expect(${a} ${operator} ${b}).${matcher}(true)`,
`expect(${a} ${operator} ${b}).${matcher}(false)`,
`expect(${a} ${operator} ${b}).not.${matcher}(true)`,
`expect(${a} ${operator} ${b}).not.${matcher}(false)`,
`expect(${b} ${operator} ${a}).${matcher}(true)`,
`expect(${b} ${operator} ${a}).${matcher}(false)`,
`expect(${b} ${operator} ${a}).not.${matcher}(true)`,
`expect(${b} ${operator} ${a}).not.${matcher}(false)`,
`expect(${a} ${operator} ${b}).${matcher}(true)`,
`expect(${a} ${operator} ${b}).${matcher}(false)`,
`expect(${a} ${operator} ${b}).not.${matcher}(true)`,
`expect(${a} ${operator} ${b}).not.${matcher}(false)`,
`expect(${b} ${operator} ${a}).${matcher}(true)`,
`expect(${b} ${operator} ${a}).${matcher}(false)`,
`expect(${b} ${operator} ${a}).not.${matcher}(true)`,
`expect(${b} ${operator} ${a}).not.${matcher}(false)`,
`expect(${b} ${operator} ${b}).not.${matcher}(false)`,
],
]);
};
const testComparisonOperator = (
operator: string,
preferredMatcher: string,
preferredMatcherWhenNegated: string,
) => {
ruleTester.run(`prefer-to-be-comparison: ${operator}`, rule, {
valid: [
'expect()',
'expect({}).toStrictEqual({})',
`expect(value).${preferredMatcher}(1);`,
`expect(value).${preferredMatcherWhenNegated}(1);`,
`expect(value).not.${preferredMatcher}(1);`,
`expect(value).not.${preferredMatcherWhenNegated}(1);`,
`expect(value).${preferredMatcher}(1);`,
...['toBe', 'toEqual', 'toStrictEqual'].reduce<string[]>(
(cases, equalityMatcher) => [
...cases,
...generateValidStringLiteralCases(operator, equalityMatcher),
],
[],
),
],
invalid: ['toBe', 'toEqual', 'toStrictEqual'].reduce<
Array<TSESLint.InvalidTestCase<'useToBeComparison', never>>
>(
(cases, equalityMatcher) => [
...cases,
...generateInvalidCases(
operator,
equalityMatcher,
preferredMatcher,
preferredMatcherWhenNegated,
),
],
[],
),
});
};
testComparisonOperator('>', 'toBeGreaterThan', 'toBeLessThanOrEqual');
testComparisonOperator('<', 'toBeLessThan', 'toBeGreaterThanOrEqual');
testComparisonOperator('>=', 'toBeGreaterThanOrEqual', 'toBeLessThan');
testComparisonOperator('<=', 'toBeLessThanOrEqual', 'toBeGreaterThan');
ruleTester.run(`prefer-to-be-comparison`, rule, {
valid: [
'expect()',
'expect({}).toStrictEqual({})',
'expect(a === b).toBe(true)',
'expect(a !== 2).toStrictEqual(true)',
'expect(a === b).not.toEqual(true)',
'expect(a !== "string").toStrictEqual(true)',
'expect(5 != a).toBe(true)',
'expect(a == "string").toBe(true)',
'expect(a == "string").not.toBe(true)',
],
invalid: [],
});