/
prefer-todo.ts
104 lines (92 loc) · 2.42 KB
/
prefer-todo.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
import { AST_NODE_TYPES, TSESLint, TSESTree } from '@typescript-eslint/utils';
import {
ParsedJestFnCall,
createRule,
getAccessorValue,
hasOnlyOneArgument,
isFunction,
isStringNode,
parseJestFnCall,
replaceAccessorFixer,
} from './utils';
function isEmptyFunction(node: TSESTree.CallExpressionArgument) {
if (!isFunction(node)) {
return false;
}
return (
node.body.type === AST_NODE_TYPES.BlockStatement && !node.body.body.length
);
}
function createTodoFixer(
jestFnCall: ParsedJestFnCall,
fixer: TSESLint.RuleFixer,
) {
if (jestFnCall.members.length) {
return replaceAccessorFixer(fixer, jestFnCall.members[0], 'todo');
}
return fixer.replaceText(
jestFnCall.head.node,
`${jestFnCall.head.local}.todo`,
);
}
const isTargetedTestCase = (jestFnCall: ParsedJestFnCall): boolean => {
if (jestFnCall.members.some(s => getAccessorValue(s) !== 'skip')) {
return false;
}
// todo: we should support this too (needs custom fixer)
if (jestFnCall.name.startsWith('x')) {
return false;
}
return !jestFnCall.name.startsWith('f');
};
export default createRule({
name: __filename,
meta: {
docs: {
category: 'Best Practices',
description: 'Suggest using `test.todo`',
recommended: false,
},
messages: {
emptyTest: 'Prefer todo test case over empty test case',
unimplementedTest: 'Prefer todo test case over unimplemented test case',
},
fixable: 'code',
schema: [],
type: 'layout',
},
defaultOptions: [],
create(context) {
return {
CallExpression(node) {
const [title, callback] = node.arguments;
const jestFnCall = parseJestFnCall(node, context.getScope());
if (
!title ||
jestFnCall?.type !== 'test' ||
!isTargetedTestCase(jestFnCall) ||
!isStringNode(title)
) {
return;
}
if (callback && isEmptyFunction(callback)) {
context.report({
messageId: 'emptyTest',
node,
fix: fixer => [
fixer.removeRange([title.range[1], callback.range[1]]),
createTodoFixer(jestFnCall, fixer),
],
});
}
if (hasOnlyOneArgument(node)) {
context.report({
messageId: 'unimplementedTest',
node,
fix: fixer => createTodoFixer(jestFnCall, fixer),
});
}
},
};
},
});