Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CSI-u/*FixTerms*/*Kitty* keyboard escape sequences #3237

Open
stevenxxiu opened this issue Jan 20, 2024 · 3 comments
Open

Use CSI-u/*FixTerms*/*Kitty* keyboard escape sequences #3237

stevenxxiu opened this issue Jan 20, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@stevenxxiu
Copy link

stevenxxiu commented Jan 20, 2024

Is your feature request related to a problem? Please describe.
I would love to have proper keyboard escape sequence support.

When I type ( in quick succession in a commit message, ([32;2u appears.

I want to bind Ctrl + Shift + p. LazyGit doesn't appear to handle that case at all.

The keyboard escape sequence is known as CSI-u/fixterms/Kitty keyboard protocol. This is implemented in many apps.

I have this enabled in WezTerm. That's probably the reason why ([32;2u appears.

Describe the solution you'd like
Full support of CSI-u/fixterms/Kitty keyboard protocol. I'm sure some Go library handles this. fixterms goes way back to 2011 per Wayback Machine.

Describe alternatives you've considered
The only alternative is to abandon the great majority of possible keyboard shortcuts.

Additional context
N/A

@stevenxxiu stevenxxiu added the enhancement New feature or request label Jan 20, 2024
@stevenxxiu stevenxxiu changed the title Use CSI-u/*Fixterms*/*Kitty* keyboard escape sequences Use CSI-u/*FixTerms*/*Kitty* keyboard escape sequences Jan 20, 2024
@stefanhaller
Copy link
Collaborator

While there would be a bit of work to do on our side to support this (or rather on gocui's side), it's primarily something that needs to be supported in tcell. They already have an issue for it: gdamore/tcell#671

@stevenxxiu
Copy link
Author

Thanks for looking into this. The gocui repo seems rather dead. Is there anything that can be done then if tcell implements it?

@stefanhaller
Copy link
Collaborator

This won't be a problem, we have our own gocui fork at https://github.com/jesseduffield/gocui and can make any required changes there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants