Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to hashbrown v0.13 #162

Merged
merged 1 commit into from Dec 19, 2022
Merged

Conversation

benesch
Copy link
Contributor

@benesch benesch commented Dec 17, 2022

No description provided.

@jeromefroe
Copy link
Owner

@benesch looks like we'll need to bump the MSRV to 1.61.0 in order to upgrade to hashbrown v0.13. Mind update the README and CI as part of this change? That should be all the additional changes we need.

@benesch
Copy link
Contributor Author

benesch commented Dec 19, 2022

Sure thing, done!

@jeromefroe
Copy link
Owner

Looks great! Thank you @benesch!

@jeromefroe jeromefroe merged commit 44e00ef into jeromefroe:master Dec 19, 2022
@benesch
Copy link
Contributor Author

benesch commented Dec 19, 2022

Thank you!

@mrcnski
Copy link

mrcnski commented Jan 22, 2023

Hello there! I was a bit confused why lru version 0.9 is a breaking change, as it seemed to only affect internals. Is it because of this MSRV bump, mentioned in the OP? Should it have been called out in the changelog, perhaps?

@jeromefroe
Copy link
Owner

Hi @mrcnski! Yea, I cut a new minor tag instead of a patch one because of the MSRV bump. Sorry for the confusion, I should have called that out in the changelog 🤦

@mrcnski
Copy link

mrcnski commented Jan 23, 2023

No worries at all @jeromefroe, thanks for clearing that up! Have a good day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants