{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":168413405,"defaultBranch":"master","name":"azure-sdk-for-js","ownerLogin":"jeremymeng","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2019-01-30T20:51:52.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/7583839?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1717784200.0","currentOid":""},"activityList":{"items":[{"before":"6b42eb9517e8353d2c21da291954a3154d61a812","after":"b500c2d4e56befb2b03308ee3951cc362b7f48c3","ref":"refs/heads/sb/close-link-before-throwing","pushedAt":"2024-06-07T23:15:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"add changelog entry","shortMessageHtmlLink":"add changelog entry"}},{"before":"69a14a6488a7f4c7accb2918904064fb3c3ea98c","after":"6b42eb9517e8353d2c21da291954a3154d61a812","ref":"refs/heads/sb/close-link-before-throwing","pushedAt":"2024-06-07T23:09:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"also close the session and remove the link","shortMessageHtmlLink":"also close the session and remove the link"}},{"before":null,"after":"69a14a6488a7f4c7accb2918904064fb3c3ea98c","ref":"refs/heads/sb/close-link-before-throwing","pushedAt":"2024-06-07T18:16:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"[ServiceBus] close link before throwing error in createRheaLink()\n\nThis PR fixes a memory leak in `createRheaLink` where in error cases we didn't\nclose the created `rhea-promise` receiver. Eventually this would lead to\nclient exceeding the quota on maximum allowed links on a connection.\n\nThe fix is to close the created receiver before we throw errors.","shortMessageHtmlLink":"[ServiceBus] close link before throwing error in createRheaLink()"}},{"before":"0b72af73cf891d662014da241bba1ece072d4761","after":null,"ref":"refs/heads/acr/fix-build-issue-29740","pushedAt":"2024-06-06T23:19:37.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"}},{"before":"d6c6ea2e859652abe54775f99d49a201817b96fb","after":null,"ref":"refs/heads/eslint/pkg-json-cjs","pushedAt":"2024-06-06T22:54:22.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"}},{"before":"9c556b6c04fda497b34defbe548d2faeecf375ac","after":"d6c6ea2e859652abe54775f99d49a201817b96fb","ref":"refs/heads/eslint/pkg-json-cjs","pushedAt":"2024-06-05T22:21:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"format","shortMessageHtmlLink":"format"}},{"before":"a2a7906adc2916870c7740e1f20e2dfce4d99755","after":"9c556b6c04fda497b34defbe548d2faeecf375ac","ref":"refs/heads/eslint/pkg-json-cjs","pushedAt":"2024-06-05T17:13:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"turn off name rule for unbranded","shortMessageHtmlLink":"turn off name rule for unbranded"}},{"before":null,"after":"a2a7906adc2916870c7740e1f20e2dfce4d99755","ref":"refs/heads/eslint/pkg-json-cjs","pushedAt":"2024-06-05T03:46:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"fix linting error in dev-tool","shortMessageHtmlLink":"fix linting error in dev-tool"}},{"before":"a11f6f9067676367814cdcefa8474abd7394545c","after":null,"ref":"refs/heads/eslint-fix-global-ignores","pushedAt":"2024-06-04T20:40:31.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"}},{"before":null,"after":"20f4d72bb4e74ab99ce37f98f38a3bfb7dc261b2","ref":"refs/heads/dependency-test-vitest","pushedAt":"2024-06-04T20:26:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"[dependency-test] support packages that moved to vitest\n\nby writing a copy of vitest config file to the test/public project and update\nrelated commands to run vitest.\n\nThis PR addresses NodeJs only.","shortMessageHtmlLink":"[dependency-test] support packages that moved to vitest"}},{"before":null,"after":"a11f6f9067676367814cdcefa8474abd7394545c","ref":"refs/heads/eslint-fix-global-ignores","pushedAt":"2024-06-04T17:15:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"format","shortMessageHtmlLink":"format"}},{"before":null,"after":"4501ba2174524f18c20a60740e4d9a0ea58fec7e","ref":"refs/heads/eslint/fix-ignores-pattern","pushedAt":"2024-06-04T00:21:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"[eslint] move monitor-opentelemetry* to flat config\n\nfix generated ignore issue","shortMessageHtmlLink":"[eslint] move monitor-opentelemetry* to flat config"}},{"before":null,"after":"490351a3009e91a52a1f8eaee913c76d9f56c868","ref":"refs/heads/engsys/consistent-import-type-separate","pushedAt":"2024-06-03T22:26:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"apply `lint:fix` result for identity packages","shortMessageHtmlLink":"apply lint:fix result for identity packages"}},{"before":null,"after":"33d4823367fc06fb7db1d5efa76fa957ac481023","ref":"refs/heads/eslint/add-unicorn","pushedAt":"2024-05-31T23:07:43.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"Ignore eslint.config files","shortMessageHtmlLink":"Ignore eslint.config files"}},{"before":"e40f5c953158269744c0ed60ed001d7d8ab7b6d5","after":"41146c21824640014511441373d3a531bd046f1a","ref":"refs/heads/sb/fix-abort-tests","pushedAt":"2024-05-30T20:58:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"improve code","shortMessageHtmlLink":"improve code"}},{"before":"4aa399ba0c9fd40b277c39faf14d5bb4c1200741","after":"e40f5c953158269744c0ed60ed001d7d8ab7b6d5","ref":"refs/heads/sb/fix-abort-tests","pushedAt":"2024-05-30T17:17:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"log and ignore error if delay promise is rejected","shortMessageHtmlLink":"log and ignore error if delay promise is rejected"}},{"before":"b5d408268ed098ccf83c1d6435bac8bbe9b11cf0","after":"4aa399ba0c9fd40b277c39faf14d5bb4c1200741","ref":"refs/heads/sb/fix-abort-tests","pushedAt":"2024-05-29T22:38:43.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"[ServiceBus] Remove verification of abort error messages in tests\n\nAfter upgrading to `@azure/abort-controller` v2, some tests that verify the\nabort error messages have been failing. It turns out that in our async\noperations because multiple callbacks are attached to the same abort signal (for\nexample, retry logic, delay calls for timeout, authentication, auto\nlock-renewing, etc.) and multiple abort errors are thrown reacting to their\nsignal being aborted. After upgrading to `@azure/abort-controller` v2, the order\nof `AbortError`s being thrown have changed thus the error we catch in the test\nis now different from the one before upgrading. It is possible that our previous\n`AbortContoller` implementation of parent-children aborter pattern implies\ncertain ordering which is different from when manually attaching callbacks.\nHowever, what's important to the consumer of our APIs in this scenario is that\nthe operation is aborted, AbortErrors are thrown, and one of them is caught,\neven a different one than before.\n\nThis PR removes verification of the error messages.\n\nI also realize that it is not useful to re-throw the error from delay for\ntimeout operation, when the delay operation is aborted either because a signal\nis aborted, or because a operation it is waiting for succeeds. So that error is\nswallowed.","shortMessageHtmlLink":"[ServiceBus] Remove verification of abort error messages in tests"}},{"before":null,"after":"b5d408268ed098ccf83c1d6435bac8bbe9b11cf0","ref":"refs/heads/sb/fix-abort-tests","pushedAt":"2024-05-29T22:38:18.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"[ServiceBus][test] Remove verification of abort error messages\n\nAfter upgrading to `@azure/abort-controller` v2, some tests that verify the\nabort error messages have been failing. It turns out that in our async\noperations because multiple callbacks are attached to the same abort signal (for\nexample, retry logic, delay calls for timeout, authentication, auto\nlock-renewing, etc.) and multiple abort errors are thrown reacting to their\nsignal being aborted. After upgrading to `@azure/abort-controller` v2, the order\nof `AbortError`s being thrown have changed thus the error we catch in the test\nis now different from the one before upgrading. It is possible that our previous\n`AbortContoller` implementation of parent-children aborter pattern implies\ncertain ordering which is different from when manually attaching callbacks.\nHowever, what's important to the consumer of our APIs in this scenario is that\nthe operation is aborted, AbortErrors are thrown, and one of them is caught,\neven a different one than before.\n\nThis PR removes verification of the error messages.\n\nI also realize that it is not useful to re-throw the error from delay for\ntimeout operation, when the delay operation is aborted either because a signal\nis aborted, or because a operation it is waiting for succeeds. So that error is\nswallowed.","shortMessageHtmlLink":"[ServiceBus][test] Remove verification of abort error messages"}},{"before":"4ac9dbb53add0dbde3ee4573b2e33716f2d1cedf","after":"912f33787ce8cf796b66eba879d98598b188fa22","ref":"refs/heads/engsys/rimraf-v5-rest","pushedAt":"2024-05-29T20:18:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"update lock file and add --glob","shortMessageHtmlLink":"update lock file and add --glob"}},{"before":null,"after":"4ac9dbb53add0dbde3ee4573b2e33716f2d1cedf","ref":"refs/heads/engsys/rimraf-v5-rest","pushedAt":"2024-05-29T17:47:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"[engsys] upgrade dev dependency rimraf to ^5.0.0\n\nmost of packages in this repo already have version v5. This PR upgrades the rest\nto not have the now deprecated v3.","shortMessageHtmlLink":"[engsys] upgrade dev dependency rimraf to ^5.0.0"}},{"before":null,"after":"6f6acaccab9625dc2eb9dfb611ef67022df17cb5","ref":"refs/heads/messaging/encode-empty-byte-array-for-missing-body","pushedAt":"2024-05-28T19:58:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"[amqp messaging] Use zero length byte array for missing message body\n\nCurrently we send a data section of `null` when message body is `null` or\n`undefined`. This works fine within JS land but cause interop issues with other\nlanguages because they don't expect a data section of null marker.\n\nThis PR changes to use empty byte array to denote body that doesn't exist, which\nis the prevailing approach in Amqp space. Internally when data type is `data`,\nwe send a data section of `Buffer.alloc(0)` to indicate empty body, and decode\n`Buffer` of zero byteLength as null on the receiving side.","shortMessageHtmlLink":"[amqp messaging] Use zero length byte array for missing message body"}},{"before":"f6ef7ac143de8b366d7b93c4f061578c686ad814","after":null,"ref":"refs/heads/servicebus-ac-v2","pushedAt":"2024-05-24T22:57:07.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"}},{"before":null,"after":"49571bda1e1fb853bae010ec1554451a08ca6387","ref":"refs/heads/fix-pnpm-lock","pushedAt":"2024-05-24T18:49:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"[engsys] fix inconsistent `tsx` version\n\nall other occurrences of `tsx` have version 4.10.5. The older version of 4.10.2\nmay have been introduced during PR merge and it is causing warnings/errors when\nrunning `rush update`. This PR change the version to be consistent.","shortMessageHtmlLink":"[engsys] fix inconsistent tsx version"}},{"before":null,"after":"4f595e5c2d1413df06217c459328062f022421bd","ref":"refs/heads/storage-ac-v2","pushedAt":"2024-05-24T18:46:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"[storage] upgrade dependency @azure/abort-controller to ^2.1.2\n\n- fix compilation errors\n- remove test cases that no longer apply.","shortMessageHtmlLink":"[storage] upgrade dependency @azure/abort-controller to ^2.1.2"}},{"before":null,"after":"f6ef7ac143de8b366d7b93c4f061578c686ad814","ref":"refs/heads/servicebus-ac-v2","pushedAt":"2024-05-24T18:21:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"[ServiceBus] upgrade dependency @azure/abort-controller to ^2.1.2\n\n- fix compilation errors\n- fix v7-beta sample tagetting version","shortMessageHtmlLink":"[ServiceBus] upgrade dependency @azure/abort-controller to ^2.1.2"}},{"before":"aaacab2273d76afd89ec2e92d44f9c2f9038efe3","after":"276c783d11076ec6eca0897e0b056a01e24c40a4","ref":"refs/heads/load-testing-ac-v2","pushedAt":"2024-05-24T17:59:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"update lock file","shortMessageHtmlLink":"update lock file"}},{"before":null,"after":"aaacab2273d76afd89ec2e92d44f9c2f9038efe3","ref":"refs/heads/load-testing-ac-v2","pushedAt":"2024-05-24T17:44:34.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"[load-testing] upgrade dependency @azure/abort-controller to ^2.1.2\n\n- fix compilation errors.\n- fix v1-beta samples targeting version\n- update tests","shortMessageHtmlLink":"[load-testing] upgrade dependency @azure/abort-controller to ^2.1.2"}},{"before":null,"after":"89ba157a1871e64663d8ad8f8cd5e5ad9d366b4c","ref":"refs/heads/ac-v2","pushedAt":"2024-05-24T16:46:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"Merge remote-tracking branch 'up/main' into ac-v2","shortMessageHtmlLink":"Merge remote-tracking branch 'up/main' into ac-v2"}},{"before":"6e7788069272bca9bf7160f9d2ae6f0c51c41fc7","after":null,"ref":"refs/heads/eslint/compat-test-only","pushedAt":"2024-05-23T23:38:44.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"}},{"before":"3b804a2bcf20bba1a0a46de5235a3c36fe906615","after":"6e7788069272bca9bf7160f9d2ae6f0c51c41fc7","ref":"refs/heads/eslint/compat-test-only","pushedAt":"2024-05-23T23:09:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jeremymeng","name":"Jeremy Meng","path":"/jeremymeng","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7583839?s=80&v=4"},"commit":{"message":"fix linting","shortMessageHtmlLink":"fix linting"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEX6gHIAA","startCursor":null,"endCursor":null}},"title":"Activity ยท jeremymeng/azure-sdk-for-js"}