fix: Ensure retrievePomProperties always returns non-null #5512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
guessing we should push another release? |
jeremylong
approved these changes
Feb 27, 2023
yes please, this breaks our pipelines |
FloEberle
approved these changes
Feb 28, 2023
Yes, think so too. Unfortunate that it was found only after release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5511
Fixes Issue #5511
Description of Change
Update code to prevent null-valued object to be returned
Have test cases been added to cover the new functionality?
no, validated with a local build using
pkg:maven/io.micronaut/micronaut-inject@3.8.5that the NPE is resolved, intend to look for either detection in an existing regression-test or addition of one in order to not have regressions in the future, but consider the bug's disruptive disruptive potential enough to first fix it and work on getting a proper test in later.