Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FP): Several FPs not suitable for our automation #5504

Merged
merged 8 commits into from
Feb 27, 2023
Merged

Conversation

aikebah
Copy link
Collaborator

@aikebah aikebah commented Feb 25, 2023

Fixed Issues: see the linked tickets

Description of Change

FP suppressions for which either the automation could not run, or the automation yields an inappropriate suppression

Have test cases been added to cover the new functionality?

no

@boring-cyborg boring-cyborg bot added the core changes to core label Feb 25, 2023
@aikebah aikebah linked an issue Feb 25, 2023 that may be closed by this pull request
@aikebah aikebah linked an issue Feb 25, 2023 that may be closed by this pull request
@aikebah aikebah linked an issue Feb 25, 2023 that may be closed by this pull request
@aikebah aikebah marked this pull request as ready for review February 26, 2023 14:18
@aikebah
Copy link
Collaborator Author

aikebah commented Feb 26, 2023

@jeremylong given the amount of libraries hit by #5502 I think it would be good to get an 8.1.1 release out when this PR is integrated

@adam-siklosi
Copy link

Hi @aikebah

When I saw the release notes for #4723 I thought the age of updating DependencyCheck version for false positive suppressions is over.
Was that a misunderstanding from my side or you are still working on some aspect of this feature?

Thanks!
Adam

@aikebah
Copy link
Collaborator Author

aikebah commented Feb 27, 2023

@adam-siklosi Not all suppressions are feasible for the automation. The automation is allowing most suppressions (the simple ones - single library, improper CPE - which is the majority of the FP reports) to have a much faster roundtrip time without a need to release (simple suppressions for one library can be handled by automation to be pushed to the published suppressions).
The more complex ones are still only processed in regular development. There is no automation in place to process manual additions to published suppressions.

@jeremylong
Copy link
Owner

@aikebah I'll release the new version shortly.

@Marcono1234
Copy link
Contributor

@aikebah, in cases where automation cannot create the suppression, would it not be possible to create the pull request manually against the generatedSuppressions branch (or manually edit the bot generated suppression as it was done in #5122 (comment))?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment