fix: Erroneous error-log for deprecated CLI flag usage when using properyfile based disablement of Node Audit Analyzer #5487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue #5483 by removing the deprecated flag error of version 3.3.3 that wrongly also fires when the node audit is disabled by the proper property-setting. As this has raised an error-log stating removal in a next release since v3.3.3 it should be fine to remove in a bugfix release.
Make the method-name clearly indicate that it does more than just check the presence of a disabling option flag in the CLI arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #5483
Description of Change
In my view, given that we are 5 majors ahead of v3 it would be safe to remove in a bugfix-release, so scheduling it for 8.1.1
Have test cases been added to cover the new functionality?
no