Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade semver4j to 4.1.1 to prevent NullPointerException #5190

Merged
merged 2 commits into from Dec 29, 2022

Conversation

nhumblot
Copy link
Collaborator

@nhumblot nhumblot commented Dec 29, 2022

Fixes Issue

Fix #5158

Description of Change

This PR fix an issue in semver4j causing a NullPointerException by upgrading it to the latest version

Have test cases been added to cover the new functionality?

no

@nhumblot nhumblot changed the title #5158 Upgrade semver4j to 4.1.1 to handle trailing whitespaces and pr… #5158 Upgrade semver4j to 4.1.1 to prevent NullPointerException Dec 29, 2022
@nhumblot nhumblot changed the title #5158 Upgrade semver4j to 4.1.1 to prevent NullPointerException fix: Upgrade semver4j to 4.1.1 to prevent NullPointerException Dec 29, 2022
@boring-cyborg boring-cyborg bot added core changes to core tests test cases labels Dec 29, 2022
@jeremylong jeremylong added this to the 7.4.3 milestone Dec 29, 2022
@jeremylong
Copy link
Owner

Should have added the test case on this earlier... Thanks for the PR - I'll release this fix shortly.

@jeremylong jeremylong merged commit e2d1389 into main Dec 29, 2022
@jeremylong jeremylong deleted the 5158-upgrade-semver4j branch December 29, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core changes to core tests test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException in Semver for alternative NPM versions
2 participants