Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve reported issues with npm #5135

Merged
merged 4 commits into from Dec 13, 2022
Merged

fix: resolve reported issues with npm #5135

merged 4 commits into from Dec 13, 2022

Conversation

jeremylong
Copy link
Owner

Resolves #5128 and #5116

@boring-cyborg boring-cyborg bot added core changes to core tests test cases labels Dec 10, 2022
Copy link
Collaborator

@aikebah aikebah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... maybe honor checkstyle's review and rename the variable to modulesRoot.... but current name is fine as well I would say.

@jeremylong jeremylong added this to the 7.4.2 milestone Dec 13, 2022
@jeremylong jeremylong merged commit df4477c into main Dec 13, 2022
@jeremylong jeremylong deleted the npm-fixes branch December 13, 2022 10:18
@ngyl88
Copy link

ngyl88 commented Dec 19, 2022

Hi @jeremylong , I noted that this is planned for the release on the milestone 7.4.2, that is currently 77% completed.

If you don't mind, I would like to ask about the expected delivery of the fixes, as we are currently using this tool to scan npm packages, which has been broken since 7.4.0. We are still tracking the closed issues, because we wish to apply the latest tool version before closing our task. If it will take some time, we might want to create another task. Thanks for your understanding.

Thank you for creating such a nice tool. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core changes to core tests test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException in Semver for hyphenated NPM version matches
3 participants