Optimize file checksums calculation #5112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checksums are frequently calculated together (see Dependency constructor) so it makes sense to only read files once to calculate all checksums together
use the already existing checksum methods instead
jeremylong
approved these changes
Dec 2, 2022
|
CodeQL flagged the use of MD5 - this is not used as a security mechanism. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
I noticed checksums can be very slow to calculate for some larger files. One of the reasons is that the file is read 3 times - once per each checksum. (See
Dependency.calculateChecksums(File).) This is easy to optimize by reading the file only once and calculating all 3 checksums together.Description of Change
There are two commits:
ChecksumclassHave test cases been added to cover the new functionality?
No new functionality added, and existing tests already cover the changed functionality.