Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude node_modules from Maven's scan path #4974

Merged
merged 1 commit into from
Oct 22, 2022
Merged

Exclude node_modules from Maven's scan path #4974

merged 1 commit into from
Oct 22, 2022

Conversation

jeremylong
Copy link
Owner

Fixes Issue #4972

99% positive the error reported in #4972 is due to how file sets work with Maven. Other places in the code we filter out scanning the node_modules directory - filtering here should prevent the reported error regarding yarn.

@boring-cyborg boring-cyborg bot added the maven changes to the maven plugin label Oct 21, 2022
Copy link
Collaborator

@aikebah aikebah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I share your analysis that it would solve the issue and is an appropriate exclude for maven projects

@jeremylong jeremylong merged commit c8b1d2f into main Oct 22, 2022
@jeremylong jeremylong added this to the 7.3.1 milestone Oct 22, 2022
@jeremylong jeremylong deleted the nodeModules branch October 22, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maven changes to the maven plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants