Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppression with multiple CVE tags will not output as unmatched when there is at least one other CVE that does match #4841

Open
Jurrie opened this issue Sep 13, 2022 · 1 comment

Comments

@Jurrie
Copy link

Jurrie commented Sep 13, 2022

Describe the bug
Since #4685 the unmatched suppression rules are outputted. I think there is a bug in this logic. When a suppression is listed with multiple CVEs, where 1 CVE will not match, there is no output if there is at least one other CVE that is matched.

Version of dependency-check used
The problem occurs using version 7.1.2 of the maven plugin.

To Reproduce
Steps to reproduce the behavior:

  1. Download https://jurr.org/owasp_dependency_check/zero_matches_suppression_rules_bug.zip
  2. Unzip
  3. Read README.txt

Expected behavior
See the README.txt contained in the zip file.

@Jurrie Jurrie added the bug label Sep 13, 2022
@aikebah aikebah added enhancement and removed bug labels Sep 14, 2022
@chadlwilson
Copy link
Contributor

To consider for this enhancement that a single rule can contain a variety of different suppression types, e.g both <cve> and <vulnerabilityName> to cover the same things being raised against multiple sources.

Example: https://github.com/gocd/gocd/blob/3afd89a219ce5331080dbd1e0f3cda439eb17b02/buildSrc/dependency-check-suppress.xml#L265-L280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants