Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom report templates via CLI #4800

Merged
merged 1 commit into from Sep 5, 2022

Conversation

gesellix
Copy link
Contributor

@gesellix gesellix commented Sep 1, 2022

Fixes Issue #4799

Description of Change

This makes the CliParser more tolerant for the --format argument. It still allows all values from Format and additionally accepts existing file paths. It won't validate if the file is a valid Velocity template.

Have test cases been added to cover the new functionality?

no (not yet)

@boring-cyborg boring-cyborg bot added the cli changes to the cli label Sep 1, 2022
Copy link
Owner

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@jeremylong jeremylong merged commit 1132b74 into jeremylong:main Sep 5, 2022
@gesellix gesellix deleted the custom-template branch September 5, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli changes to the cli
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants