Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Bazel pinned maven_install.json files #4772

Closed
dhalperi opened this issue Aug 24, 2022 · 1 comment · Fixed by #4773
Closed

Support for Bazel pinned maven_install.json files #4772

dhalperi opened this issue Aug 24, 2022 · 1 comment · Fixed by #4773
Milestone

Comments

@dhalperi
Copy link
Contributor

Is your feature request related to a problem? Please describe.

This is a new type of Java lockfile (think: requirements.txt produced by something like pip-compile).

Describe the solution you'd like
It would be nice if DependencyCheck supported it. Since all dependencies are fully transitively resolved,
I believe that all that needs to be done is creating a virtual dependency corresponding to each dependency.

Describe alternatives you've considered
I thought about:

  • producing a bundle jar, and scanning that. Seems heavyweight and relies on the bundling process not to lose any versions.

  • auto-generating another manifest (pom.xml?). If DependencyCheck supports scanning a pom.xml in isolation, great. But if not, we recurse. Either way, seems simpler to support this format.

Additional context

For more info, see: https://github.com/bazelbuild/rules_jvm_external/#pinning-artifacts-and-integration-with-bazels-downloader

Note: This is not a niche homegrown thing, but a standard used in increasingly many projects. GitHub search of a sentinel used in the pinned file finds 175 repos at the time of writing: https://github.com/search?q=THERE_IS_NO_DATA_ONLY_ZUUL&type=code

@aikebah aikebah added this to the 7.1.3 milestone Sep 11, 2022
@aikebah aikebah linked a pull request Sep 11, 2022 that will close this issue
@aikebah aikebah closed this as completed Sep 11, 2022
@OrangeDog
Copy link

175 repos is indeed very niche.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants