Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the new database schema for Oracle database #2899

Merged
merged 8 commits into from
Oct 19, 2020

Conversation

aikebah
Copy link
Collaborator

@aikebah aikebah commented Oct 18, 2020

Fixes Issue #2755

Description of Change

Updated the Oracle initialization script and custom queries to match up with the new database layout of v6

Optimized querying Oracle by making larger fetches than by default to more closely match the other DBMSes that fetch ALL results directly into the ResultSet.

Have test cases been added to cover the new functionality?

No, not feasible as there is no Oracle DB to run the testcases against.
Some manual tests run with various projects to compare the vulnerabilities output between them and a manual comparison of post-initial load counts for all tables between PostgreSQL and Oracle to make sure both import the same number of records for each.

@boring-cyborg boring-cyborg bot added the core changes to core label Oct 18, 2020
@jeremylong jeremylong added this to the 6.0.3 milestone Oct 19, 2020
@jeremylong jeremylong merged commit 666d669 into jeremylong:main Oct 19, 2020
@jeremylong
Copy link
Owner

@aikebah thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core changes to core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants