Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bit logic improvement #2051

Closed
bigstinky86 opened this issue Jul 9, 2019 · 1 comment
Closed

A bit logic improvement #2051

bigstinky86 opened this issue Jul 9, 2019 · 1 comment
Labels
bug
Milestone
5.1.1

Comments

@bigstinky86
Copy link
Contributor

Hi there,

During a code testing with usage of the dependency-check cli we've found out that with several report types set in cli arguments it runs as much times as output formats specified (-f flag).

I'd like to suggest improvement as it dosen't make sense to run scan in this way. I believe it should be better to run scan one time and the report generation as much as was specified in cli args :)
bigstinky86 pushed a commit to bigstinky86/DependencyCheck that referenced this issue Jul 9, 2019
[jeremylong#2051] - Report generation run logic improvement
07393f6
@bigstinky86 bigstinky86 mentioned this issue Jul 9, 2019
Merged
jeremylong pushed a commit that referenced this issue Jul 10, 2019
@bigstinky86 @jeremylong
[#2051] - Report generation run logic improvement (#2052)
97ac098
@jeremylong
Copy link
Owner

Thanks for noticing the error and submitting the PR! We are likely going to be pushing a release this weekend.

@jeremylong jeremylong added this to the 5.1.1 milestone Jul 15, 2019
@lock lock bot locked and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.1.1
Development

No branches or pull requests
2 participants
@jeremylong @bigstinky86