Add support for Oracle 12 limit/offset syntax #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add special hanling for limit N offset 0 Oracle query optimizer can not recognize ROWNUM < 10 when ROWNUM is aliased in subquery. Adding special check for offset being 0 eliminates subquery, allowing database to detect COUNT STOPKEY operation * Use new syntax for FETCH NEXT ROWS for Oracle starting with v12, unless locking is used
timon
changed the title
|
Thanks for the patch. This looks good, I'll merge and test later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oracle query optimizer can not recognize ROWNUM < 10 when ROWNUM is
aliased in subquery.
Adding special check for offset being 0 eliminates subquery, allowing
database to detect COUNT STOPKEY operation