Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gzip compression from stapler #130

Open
jtnord opened this issue Sep 20, 2017 · 2 comments
Open

remove gzip compression from stapler #130

jtnord opened this issue Sep 20, 2017 · 2 comments

Comments

@jtnord
Copy link
Member

jtnord commented Sep 20, 2017

Stapler adds some code to do gzip compression on the fly.

However there are various routes as pointed out in the code.

All modern containers (tomcat, weblogic, jetty) have support built in for doing compression which alleviates these tricks.

Therefore in the modern age, just remove any support in stapler for compression handling and make users user their servlet container appropriately if they desire the configuration.

@jglick
Copy link
Member

jglick commented Sep 20, 2017

If you can patch Winstone to apply compression by default (or perhaps at an option—unclear you want it for clients on the same LAN) then sure, would be great to simplify the code here.

@jtnord
Copy link
Member Author

jtnord commented Sep 21, 2017

quote from the jetty docs..

The Jetty GzipHandler is a compression handler that you can apply to any dynamic resource (servlet). It fixes many of the bugs in commonly available compression filters: it works with asynchronous servlets; it handles all ways to set content length. It has been tested with Jetty continuations and suspending requests.

my plan was to remove the support in stapler and then it is up to the end user using stapler to enable it (either via a load balancer, or configuration e.g. tomcat compression option in connector and to add the jetty servlet dynamically in winstone if a flag to disable compression it is not provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants