Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interception of return statements in closures in sandboxed Groovy scripts #479

Merged
merged 1 commit into from Dec 8, 2022
Merged

Fix interception of return statements in closures in sandboxed Groovy scripts #479

merged 1 commit into from Dec 8, 2022

Conversation

dwnusbaum
Copy link
Member

See jenkinsci/groovy-sandbox#100 and jenkinsci/groovy-sandbox#99.

Tests are upstream, and I don't see any particular reason to duplicate them here.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@dwnusbaum dwnusbaum added the bug label Dec 8, 2022
@dwnusbaum dwnusbaum requested a review from a team December 8, 2022 18:20
@dwnusbaum dwnusbaum merged commit d93135a into jenkinsci:master Dec 8, 2022
@dwnusbaum dwnusbaum deleted the groovy-sandbox-1.32 branch December 8, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

@car-roll car-roll car-roll approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@dwnusbaum @jglick @car-roll