Adapt generic-whitelist to handle addition of String#stripIndent method in Java 15 #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-aerts
force-pushed
the
whitelist-strip
branch
from
585e25d
to
6517737
Compare
dwnusbaum
reviewed
Sep 6, 2022
src/test/java/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/StaticWhitelistTest.java
Outdated
Show resolved
Hide resolved
`stripIndent` eclipses the `DefaultGroovyMethods` which is already in the generic-whitelist. Scripts already using this method were breaking when the JVM was upstepped as it would choose standard implementation over the one provided by groovy.
steven-aerts
force-pushed
the
whitelist-strip
branch
from
6517737
to
4a821ae
Compare
dwnusbaum
changed the title
dwnusbaum
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stripIndenteclipses theDefaultGroovyMethodswhich is already in the generic-whitelist.Scripts already using this method were breaking when the JVM was upstepped as it would choose standard implementation over the one provided by groovy.
Looking at git history it is not clear to me if you require a jira ticket. If so let me know the I create one.