Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow some Math related methods #308

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Allow some Math related methods #308

merged 2 commits into from
Sep 28, 2020

Conversation

daniel-beck
Copy link
Member

Untested.

dwnusbaum
dwnusbaum requested changes Sep 28, 2020
View reviewed changes
Copy link
Member

@dwnusbaum dwnusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new signatures look fine, but it would be good to go ahead and add all of the methods added in Java 8 as well as the two constants at the same time, so I added suggestions for all of them.

src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/generic-whitelist Show resolved Hide resolved
src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/generic-whitelist Show resolved Hide resolved
src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/generic-whitelist Show resolved Hide resolved
src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/generic-whitelist Show resolved Hide resolved
src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/generic-whitelist Show resolved Hide resolved
src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/generic-whitelist Show resolved Hide resolved
src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/generic-whitelist Show resolved Hide resolved
src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/generic-whitelist Show resolved Hide resolved
@daniel-beck @dwnusbaum
Apply suggestions from code review
8f2874a 
Co-authored-by: Devin Nusbaum <dwnusbaum@users.noreply.github.com>
@dwnusbaum
Copy link
Member

The Windows branch timed out, will try a rebuild.

@dwnusbaum dwnusbaum closed this Sep 28, 2020
@dwnusbaum dwnusbaum reopened this Sep 28, 2020
@dwnusbaum dwnusbaum merged commit 496f2eb into jenkinsci:master Sep 28, 2020
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwnusbaum dwnusbaum dwnusbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@daniel-beck @dwnusbaum