Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side-port <runOrder>alphabetical</runOrder> from plugin POM #371

Open
basil opened this issue Jan 17, 2023 · 3 comments
Open

Side-port <runOrder>alphabetical</runOrder> from plugin POM #371

basil opened this issue Jan 17, 2023 · 3 comments

Comments

@basil
Copy link
Member

basil commented Jan 17, 2023

https://github.com/jenkinsci/plugin-pom/blob/a316c25e449b4ba43267a97fedc17cec74c9253a/pom.xml#L779 is useful enough that Jenkins core also defines it. I think it would make more sense for this to be defined in the parent POM so that it applies to all Jenkins core components (consistent with it being applied to all Jenkins plugins), at which point the customization could be removed from core.

@jglick
Copy link
Member

jglick commented Jan 17, 2023

(compare jenkinsci/plugin-pom#92)

@basil
Copy link
Member Author

basil commented Jan 17, 2023

Should this issue be assigned to you? As far as I can tell jenkinsci/plugin-pom#92 was incomplete in that it applied to only one of our two parent POMs. In general any change that is made to one parent POM should also be applied to the other, unless there is a compelling reason to increase the already large technical debt of having two largely duplicate parent POMs. Yes this is painful but that should also serve as an incentive to unify the two POMs.

@basil
Copy link
Member Author

basil commented Mar 29, 2023

No response to my question 2 months and 12 days later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants