Remove gmaven-plugin
#346
Merged
Remove gmaven-plugin
#346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #42. A GItHub code search for
user:jenkinsci path:pom.xml "gmaven-plugin"only yielded results in plugins (not affected by changes to this POM) and https://github.com/jenkinsci/lib-groovy-guice-binder/blob/ed3447b4ed59aa487cda6690072211c1678de3c6/pom.xml#L16-L30 (which declares an explicit version, so it is also not affected by changes to this POM), so this plugin is safe to remove. To test this change I successfully built Jenkins core with the changes from this PR (modulo having to fix a SpotBugs warning from an unrelated PR).