Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename maven-hpi-plugin.version to hpi-plugin.version #259

Merged
merged 1 commit into from May 8, 2022
Merged

Rename maven-hpi-plugin.version to hpi-plugin.version #259

merged 1 commit into from May 8, 2022

Conversation

basil
Copy link
Member

@basil basil commented May 8, 2022

Consistent with https://github.com/jenkinsci/plugin-pom/blob/c772be96e570f721b39f200de46795914884104e/pom.xml#L75=.

Why not resolve the inconsistency in the other direction? Because

Artifact Ids of the format maven-___-plugin are reserved for
plugins in the Group Id org.apache.maven.plugins
[…]
In the future this error will break the build.

@basil basil added the breaking label May 8, 2022
@basil basil merged commit bf2e96a into jenkinsci:master May 8, 2022
@basil basil deleted the hpi-plugin-property branch May 8, 2022 17:48
@basil basil mentioned this pull request Jun 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basil @timja