Sideport of JENKINS-54842 to pom
#246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward sideport of jenkinsci/plugin-pom#523 from
plugin-pomtopom. The main change of substance here is that we are now skipping Animal Sniffer whenreleaseis set (i.e., when building with a Java 9 or later compiler, even when we build Java 8 bytecode). The switch from XML configuration to properties is not necessary in this repository as it was in jenkinsci/plugin-pom#523 (there is noInitializermojo manipulating these values for core or core components), but I think there is value in keeping these two repositories (which are largely copypasta of each other) as similar as possible in order to make it easier to sideport other changes in the future without merge conflicts.