Skip to content

Remove unused showDeprecation parameter #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

basil
Copy link
Member

@basil basil commented Jan 9, 2023

Problem

Building a plugin with Maven 4.0.0-alpha-3 results in (among other problems)

[INFO] ------------------------------------------< org.jenkins-ci.plugins:text-finder >------------------------------------------
[INFO] Building Text Finder 1.23-SNAPSHOT
[INFO]   from pom.xml
[INFO] ---------------------------------------------------------[ hpi ]----------------------------------------------------------
[WARNING] Parameter 'showDeprecation' is unknown for plugin 'maven-hpi-plugin:3.38:validate (default-validate)'
[WARNING] Parameter 'showDeprecation' is unknown for plugin 'maven-hpi-plugin:3.38:validate-hpi (default-validate-hpi)'
[WARNING] Parameter 'showDeprecation' is unknown for plugin 'maven-hpi-plugin:3.38:insert-test (default-insert-test)'
[WARNING] Parameter 'showDeprecation' is unknown for plugin 'maven-hpi-plugin:3.38:test-hpl (default-test-hpl)'
[WARNING] Parameter 'showDeprecation' is unknown for plugin 'maven-hpi-plugin:3.38:resolve-test-dependencies (default-resolve-test-dependencies)'
[WARNING] Parameter 'showDeprecation' is unknown for plugin 'maven-hpi-plugin:3.38:test-runtime (default-test-runtime)'
[WARNING] Parameter 'showDeprecation' is unknown for plugin 'maven-hpi-plugin:3.38:hpi (default-hpi)'

Evaluation

This code was originally added in jenkinsci/jenkins@5dfb1ad. At the time, compilation was handled by maven-hpi-plugin rather than by maven-compiler-plugin. Compilation was switched back to the standard maven-compiler-plugin in jenkinsci/maven-hpi-plugin@7c3969e, and the mojo with the showDeprecation option was deleted in jenkinsci/maven-hpi-plugin@334506f, but the configuration parameter remained. Specifying this parameter seems to have been ignored in Maven 3.x but is now showing a warning in Maven 4.x.

Solution

Remove the unused parameter.

Testing done

Verified that the warning was no longer shown after this parameter was removed and that compilation still succeeded.

@basil basil added the internal label Jan 9, 2023
@basil basil merged commit 5b557ac into jenkinsci:master Jan 9, 2023
@basil basil deleted the showDeprecation branch January 10, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants