Inline Maven property incrementals.url for Maven 4 support
#666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building plugins with Maven 4 (alpha) fails with: > 'profiles.profile[consume-incrementals].repositories.repository.[incrementals].url' contains an expression but should be a constant. @ org.jenkins-ci.plugins:plugin:4.53 This has already been reported to Jenkins [1] and Maven [2] and was declared as an intentional change. [1] https://issues.jenkins.io/browse/JENKINS-67878 [2] https://issues.apache.org/jira/browse/MNG-7420
|
Did maven 4 get a rid of interpolation of URLs of any kind 🤔 |
basil
reviewed
Jan 9, 2023
There was a problem hiding this comment.
If merged, this would render the documentation at https://github.com/jenkinsci/incrementals-tools#offline-testing obsolete, implying the need for a corresponding documentation update.
froque
added a commit
to froque/incrementals-tools
that referenced
this pull request
Jan 10, 2023
This is due to Maven 4 support [1]. Building plugins with Maven 4 (alpha) fails with: > 'profiles.profile[consume-incrementals].repositories.repository.[incrementals].url' contains an expression but should be a constant. @ org.jenkins-ci.plugins:plugin:4.53 This has already been reported to Jenkins [2] and Maven [3] and was declared as an intentional change. [1] jenkinsci/plugin-pom#666 [2] https://issues.jenkins.io/browse/JENKINS-67878 [3] https://issues.apache.org/jira/browse/MNG-7420
6 tasks
|
I have give it a go updating the instructions with jenkinsci/incrementals-tools#33 |
basil
approved these changes
Jan 19, 2023
basil
changed the title
incrementals.url for Maven 4 support
jglick
reviewed
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building plugins with Maven 4 (alpha) fails with:
This has already been reported to Jenkins [1] and Maven [2] and was declared as an intentional change.
[1] https://issues.jenkins.io/browse/JENKINS-67878
[2] https://issues.apache.org/jira/browse/MNG-7420
Ensure you have provided tests - that demonstrates feature works or fixes the issue