Remove managed dependency on Objenesis #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objenesis is a relatively obscure library used by very few plugins: of the popular plugins, the only one I know of that consumes it directly is
git-client. While I think it makes sense forjenkinsci/plugin-pom(and by extension,jenkinsci/pom) to manage the versions of popular libraries like Hamcrest, JUnit, and Mockito, doing so for a library like Objenesis seems less appropriate given how rarely that library is used. Better for the few consumers likegit-clientthat rely on it to manage the version on their own. To test this I verified thatorg.jenkinsci.plugins.gitclient.CliGitAPIImplTestworked after this change (and after updatinggit-clientto explicitly specify the Objenesis version).