[JENKINS-64508] Add extension point for globally defined when conditions #409
Conversation
abayer
commented
Dec 22, 2020
abayer
commented
- JENKINS issue(s):
- JENKINS-64508
- Description:
- Adds a new extension point and parse/transformation logic for globally defined when conditions that will be evaluated for every stage run on the controller when configured.
- Also get the debug pretty printing for post-AST transformation to actually do something kinda useful again.
- Documentation changes:
- n/a - no user-facing changes
- Users/aliases to notify:
- ...
Also get the debug pretty printing for post-AST transformation to actually do something kinda useful again. Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer
force-pushed
the
when-runtime-contributor
branch
from
b7a6bf0 to
599c3f0
Compare
Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
|
neat |
| /* | ||
| * The MIT License | ||
| * | ||
| * Copyright (c) 2021, CloudBees, Inc. |
There was a problem hiding this comment.
I’m being proactive since I don’t expect this to merge this year. =)
| int result = super.hashCode(); | ||
| result = 31 * result + (getStageName() != null ? getStageName().hashCode() : 0); | ||
| result = 31 * result + (getStage() != null ? getStage().hashCode() : 0); | ||
| return result; |
There was a problem hiding this comment.
Use Objects.hashCode instead?
Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
| * When container generated when adding invisible global when conditions to a stage, containing the new conditions and | ||
| * any explicitly defined ones. When created with existing conditions, the existing when container is stored for use as | ||
| * well. This is used as a marker to avoid validation, JSON/Groovy generation, etc for the generated container. |
There was a problem hiding this comment.
This needs clarification. Maybe at least use Javadoc code markers to indicate when you are talking about when and when you are not.
| @@ -321,7 +321,7 @@ class ModelParser implements Parser { | |||
|
|
|||
| // Lazily evaluate prettyPrint(...) - i.e., only if AST_DEBUG_LOGGING is true. | |||
| astDebugLog { | |||
| "Transformed runtime AST:\n${ -> prettyPrint(pipelineBlock.whole.arguments)}" | |||
| "Transformed runtime AST:\n${ -> prettyPrint(src)}" | |||
There was a problem hiding this comment.
Perhaps you could add a test where astDebugLog is enabled to protect it from future breakage?
There was a problem hiding this comment.
Good idea - I'll see what I can do.
There was a problem hiding this comment.
This is impressively difficult to really test - it needs a ModuleNode passed to it, specifically one that's been generated by RuntimeASTTransformer from a SourceUnit and a parsed ModelASTPipelineDef so that it'll actually look like the real thing. Lemme think on this...
There was a problem hiding this comment.
...doesn't help that for some reason I can't run tests from intellij right now. heh.
|
@bitwiseman - yup, no syntax changes of any kind. |
Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
|
Thanks, @bitwiseman! |
