Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakiness in BuildTriggerTest #226

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

raul-arabaolaza
Copy link
Contributor

There was the possibility of a race condition where the queue was empty but the downstream job not yet added to it, resulting in assertions about the downstream being checked too early and fail.

Show in a CI run under heavy load, not something usual, but this change should remove the possibility

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

There was the possibility of a race condition where the queue was empty
but the downstream job not yet added to it, resulting in assertions being
check too early and fail.

Show in a CI run under heavy load, not something usual, but this change
should remove the possibility
@olamy olamy merged commit b8f2425 into jenkinsci:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants