Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate project page entries (workspace, recent changes, test result) #281

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

NotMyFault
Copy link
Member

The change proposed deduplicates entries on the project page. The maven plugin depends on the JUnit plugin to be installed, which already adds a link to the test results, the current implementation adds another one:
a

@NotMyFault
Copy link
Member Author

/label bug

@timja
Copy link
Member

timja commented Jul 25, 2022

/label bug

2 similar comments
@timja
Copy link
Member

timja commented Jul 25, 2022

/label bug

@NotMyFault
Copy link
Member Author

/label bug

@comment-ops-bot comment-ops-bot bot added the bug label Jul 25, 2022
@NotMyFault
Copy link
Member Author

cc @olamy and apologizes for the comment spam :P

@timja timja requested a review from olamy July 25, 2022 10:20
@olamy
Copy link
Member

olamy commented Jul 26, 2022

cc @olamy and apologizes for the comment spam :P

/label no problem 🤣

@olamy
Copy link
Member

olamy commented Jul 26, 2022

@NotMyFault it looks you're removing too much here :)

@NotMyFault
Copy link
Member Author

@NotMyFault it looks you're removing too much here :)

Oh, I forgot to mention that I applied jenkinsci/jenkins#6918 while at it.
Core removed those from the main page in favor of the sidepanel.

@olamy olamy changed the title fix: Deduplicate project page entries Remove duplicate project page entries (workspace, recent changes, test result) Jul 26, 2022
@olamy olamy added enhancement and removed bug labels Jul 26, 2022
@olamy
Copy link
Member

olamy commented Jul 26, 2022

@NotMyFault it looks you're removing too much here :)

Oh, I forgot to mention that I applied jenkinsci/jenkins#6918 while at it. Core removed those from the main page in favor of the sidepanel.

no worries. I have updated the PR title.
thanks

@olamy olamy merged commit e01a7e0 into jenkinsci:master Jul 26, 2022
@NotMyFault NotMyFault deleted the fix/master/deduplicate-entries branch July 26, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants