Add a warning when using deprecated or insecure SCM URLs #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
approved these changes
Nov 12, 2022
basil
changed the title
Vlatombe
reviewed
Jan 11, 2023
|
|
||
| private static final String GIT_URLS_ARE_DEPRECATED = "git:// URLs are deprecated"; | ||
| private static final String HTTP_URLS_ARE_INSECURE = "http:// URLs are insecure"; | ||
| private static final String SSH_URLS_DO_NOT_WORK_WELL_WITH_PCT = "ssh:// URLs do not work well with PCT"; |
There was a problem hiding this comment.
I don't think it's really an argument. If they don't work well with pct as is, PCT should run with something like
[url "https://github.com/"]
insteadOf = "ssh://git@github.com:"
pushInsteadOf = "ssh://git@github.com:"
in its git configuration, guaranteeing that https is used in a homogeneous way even if the plugin has ssh configured.
Other variants can be used for other protocols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variety of plugins use deprecated (e.g.
git://``) or insecure (e.g.,http://`) SCM URLs, or URLs that cause problems for PCT. This PR adds a new (soft) warning that highlights such problems and provides a correction to the user. This shouldn't be very disruptive since I have already filed PRs to update the most egregious violations. I tested this on some of the same changes that I already filed PRs for to confirm that the suggestions match what I actually submitted in the PRs (before authoring this change).