Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip model validation of resolved POMs #326

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Conversation

basil
Copy link
Member

@basil basil commented Apr 1, 2022

Chases away the new warnings inadvertently introduced in #310:

[INFO] --- maven-compiler-plugin:3.10.1:testCompile (default-testCompile) @ git-client ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 66 source files to /home/basil/src/jenkinsci/git-client-plugin/target/test-classes
[INFO] 
[INFO] --- maven-hpi-plugin:3.27-SNAPSHOT:test-hpl (default-test-hpl) @ git-client ---
[INFO] Generating /home/basil/src/jenkinsci/git-client-plugin/target/test-classes/the.hpl
[INFO] 
[INFO] --- maven-hpi-plugin:3.27-SNAPSHOT:resolve-test-dependencies (default-resolve-test-dependencies) @ git-client ---
[INFO] 
[INFO] --- gmavenplus-plugin:1.13.1:compileTests (test-in-groovy) @ git-client ---
[INFO] No sources specified for compilation. Skipping.

Fixes #325.

@basil basil requested review from jglick and MarkEWaite April 1, 2022 16:09
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection from me, but I'm not a credible reviewer of maven plugin changes.

I assume that changing the model validation level will change the messages being output but should not change the results of the goal being executed.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. In this context we do not care about validation warnings. Might help with some other irrelevant noise as well.

@jglick jglick added the bug label Apr 1, 2022
@MarkEWaite MarkEWaite merged commit b1102fd into jenkinsci:master Apr 1, 2022
@basil basil deleted the model branch April 1, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'distributionManagement.status' must not be specified.
3 participants