Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert support targetPath property for webResources #300

Merged
merged 2 commits into from
Feb 23, 2022

Conversation

timja
Copy link
Member

@timja timja commented Feb 23, 2022

Fixes #299

The above change switched the resource path to:

target/solarized-theme

instead of

src/main/webapp

Which prevented live reload of webapp resources which is critical when doing UI development.
(Restarting the hpi:run isn't enough either you had to run a packaging goal too to work around it)

It may be possible to add multiple directories to the resource path but not sure if having both src and target will work.

I tried adding an integration test for this but what I had passed both before and after this change 😢
https://github.com/jenkinsci/maven-hpi-plugin/compare/master...timja:fix-live-reload?expand=1

I've manually tested this and it fixes the issue, full steps are in the issue description (#299)

@timja timja requested review from sephiroth-j and a team February 23, 2022 09:11
@timja timja added the bug label Feb 23, 2022
@daniel-beck
Copy link
Member

daniel-beck commented Feb 23, 2022

Could stapler.resourcePath be updated to match?

Nvm, looks like you tried that.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can cut a release (not sure offhand who else can), so let me know.

@timja
Copy link
Member Author

timja commented Feb 23, 2022

@timja timja merged commit 9e82b7e into jenkinsci:master Feb 23, 2022
@timja timja deleted the revert-web-resources branch February 23, 2022 15:03
@timja
Copy link
Member Author

timja commented Feb 23, 2022

Released https://github.com/jenkinsci/maven-hpi-plugin/releases/tag/maven-hpi-plugin-3.25

@jglick
Copy link
Member

jglick commented Feb 23, 2022

jenkinsci/plugin-pom#509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live reloading of webapp resources broken
3 participants