Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim form fields #96

Merged
merged 2 commits into from Mar 8, 2021
Merged

Trim form fields #96

merged 2 commits into from Mar 8, 2021

Conversation

darinpope
Copy link
Contributor

Adding trimming to the following attributes:

  • SMTP server (smtpHost)
  • User Name (authentication/user)
  • SMTP Port (smtpHost)
  • Reply-To Address (replyToAddress)
  • Charset (charset)

Also standardized the reference to Util.fixEmptyAndTrim

Signed-off-by: Darin Pope darin@planetpope.com

Adding trimming to the following attributes:

* SMTP server (smtpHost)
* User Name (authentication/user)
* SMTP Port (smtpHost)
* Reply-To Address (replyToAddress)
* Charset (charset)

Also standardized the reference to Util.fixEmptyAndTrim

Signed-off-by: Darin Pope <darin@planetpope.com>
@darinpope
Copy link
Contributor Author

This PR attempts to fix the fields that have space padded inputs in the image:

Screen Shot 2020-10-13 at 5 29 16 PM

@darinpope
Copy link
Contributor Author

Can someone force another build? Looks like "java.net.SocketTimeoutException: Read timed out" popped up on the linux-8 agent.

Signed-off-by: Darin Pope <darin@planetpope.com>
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@darinpope darinpope changed the title Trim white space Hacktoberfest: Trim white space Oct 24, 2020
@alecharp
Copy link
Member

alecharp commented Nov 2, 2020

Thank you for your contribution.

@ottlinger
Copy link
Contributor

@oleg-nenashev Could this PR be merged as it greatly simplifies usage of this plugin ? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants