Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join Gitter channel to discuss your ideas with the community #405

Merged
merged 5 commits into from Nov 26, 2022

Conversation

Jagrutiti
Copy link
Contributor

@Jagrutiti Jagrutiti commented Nov 21, 2022

Added link to join Gitter chat also for contributors

Testing done

NN

Proposed upgrade guidelines

N/A

Localizations

  • English

Submitter checklist

  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples).
    • Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during the upgrade.
  • [ ] There is automated testing or an explanation that explains why this change has no tests.
  • [ ] New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • [ ] New public functions for internal use only are annotated with @NoExternalUse. In case it is used by non java code the Used by {@code <panel>.jelly} Javadocs are annotated.
  • [ ] New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • [ ] New or substantially changed JavaScript is not defined inline and does not call eval to ease the future introduction of Content Security Policy (CSP) directives (see documentation).
  • [ ] For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • [ ] For new APIs and extension points, there is a link to at least one consumer.
  • [ ] Any localizations are transferred to *.properties files.

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There is at least one (1) approval for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • [ ] If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • [ ] java code changes are tested by automated test.

@Jagrutiti Jagrutiti requested a review from a team as a code owner November 21, 2022 15:34
@mPokornyETM
Copy link
Contributor

@Jagrutiti
Copy link
Contributor Author

Rebased: #406

Co-authored-by: Martin Pokorny <89339813+mPokornyETM@users.noreply.github.com>
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great for me.

@mPokornyETM mPokornyETM changed the title doc: updated readme with gitter channel link Join Gitter channel to discuss your ideas with the community Nov 26, 2022
@mPokornyETM mPokornyETM merged commit 9f5dd8b into jenkinsci:master Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants