Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-66247] Call Index.listClassNames #52

Merged
merged 6 commits into from Dec 1, 2022

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 29, 2021

Downstream of jenkinsci/lib-annotation-indexer#12. Amends #50. Unfortunately we cannot use this in plugin-pom any time soon because the version of access-modifier-checker must remain somehow compatible (not throw exceptions) when working with an older version of annotation-indexer present in core. Thus we cannot upgrade the checker until the minimum core version (some LTS) includes the dependency bump.

@jglick jglick marked this pull request as ready for review July 29, 2021 20:58
@jglick jglick requested review from timja and basil July 29, 2021 20:58
@jglick jglick marked this pull request as draft July 30, 2021 13:22
@jglick
Copy link
Member Author

jglick commented Jul 30, 2021

Marking as draft since I am not sure when it will be safe to merge this (without blocking unrelated changes from being released).

@basil
Copy link
Member

basil commented Dec 1, 2022

Can this be moved out of draft now that the build toolchain requires 2.361 or newer?

@jglick
Copy link
Member Author

jglick commented Dec 1, 2022

So jenkinsci/lib-annotation-indexer#12 went into 1.15 integrated via jenkinsci/jenkins#5639 in 2.305 ✔️

@jglick jglick marked this pull request as ready for review December 1, 2022 19:32
@basil basil merged commit 643a650 into jenkinsci:master Dec 1, 2022
@jglick jglick deleted the listClassNames-JENKINS-66247 branch December 1, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants