Add getSuites() method in TestResultImpl

[topikachu]

There's an issue that testReport/api/json doesn't display the suites list. Add the missing getSuites method in the TestResultImpl interface, and integrate it with Junit TestResult.

junit-sql-storage plugin will adopt this interface once it is released.

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[timja]

Can you file a pull request to the sql storage plugin please?

[topikachu]

Can you file a pull request to the sql storage plugin please?

I will after this change is published.
I create a new method, getSuites(), in the TestResultImpl.
This method has default implementation so won't break current Jenkins instance.

[timja]

We prefer that at least one API consumer is provided so that the API can be evaluated together with the implementation before the API is published as once the API is published its hard to change.

You can consumer the incremental (release candidate) version from the pull request as the dependency, (your latest build is 1166.v2936b_5c7cb_e1, can be seen at https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/junit/1166.v2936b_5c7cb_e1/, or by clicking on the 'Incrementals' GitHub check)

[topikachu]

https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/junit/1166.v2936b_5c7cb_e1/

That's good that I can test with pr build.
Please check jenkinsci/junit-sql-storage-plugin#263

[timja]

Can you adopt the smoke test please to show this is doing what's expected?
https://github.com/topikachu/junit-plugin/blob/2936b5c7cbe18c9d5c1b0a731fb6dc642bf072c7/src/test/java/io/jenkins/plugins/junit/storage/TestResultStorageJunitTest.java#L161

[topikachu]

Can you adopt the smoke test please to show this is doing what's expected? https://github.com/topikachu/junit-plugin/blob/2936b5c7cbe18c9d5c1b0a731fb6dc642bf072c7/src/test/java/io/jenkins/plugins/junit/storage/TestResultStorageJunitTest.java#L161

Done!