Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't destroy credentials when re-creating organization folders #1251

Merged
merged 3 commits into from Jul 1, 2022

Conversation

jamietanna
Copy link
Contributor

Similar to 8d8ea63, we should be able
to support organization folders not losing their credentials.

This requires we bump our dependency of credentials to pick up the
branch-api dependency.

We need to handle the various bits of metadata available in the
OrganizationFolders, so our tests are slightly more complex than we
usually have.

Co-authored-by: Jean-François Roche jfroche@affinitic.be

Closes JENKINS-44681.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Picks up from #1248.

As it's a `Folder` object we're referencing, so this makes it a bit
clearer.
Similar to 8d8ea63, we should be able
to support organization folders not losing their credentials.

This requires we bump our dependency of `credentials` to pick up the
`branch-api` dependency.

We need to handle the various bits of metadata available in the
`OrganizationFolder`s, so our tests are slightly more complex than we
usually have.

Co-authored-by: Jean-François Roche <jfroche@affinitic.be>

Closes JENKINS-44681.
@jamietanna jamietanna merged commit 610fc71 into master Jul 1, 2022
@jamietanna jamietanna deleted the defect/org-folder-secrets branch July 1, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant