Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-66189 Use dynamic DSL instead of outdated PostBuildScript syntax #1240

Merged
merged 2 commits into from Jul 18, 2022
Merged

JENKINS-66189 Use dynamic DSL instead of outdated PostBuildScript syntax #1240

merged 2 commits into from Jul 18, 2022

Conversation

dheid
Copy link
Contributor

@dheid dheid commented Jul 26, 2021

Hi @daspilker!

A user complained in https://issues.jenkins.io/browse/JENKINS-66189 that his Job DSL generated PostBuildScript configuration fails. That's because I removed some deprecated configuration options in version 3.x and forgot that there is a non-dynamic DSL in the Job DSL plugin.

To be sure, no one uses the old syntax any longer, please let us remove the entries from the Job DSL plugin. I removed them in this pull request.

Best regards

Daniel

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jamietanna jamietanna self-requested a review October 27, 2021 13:03
@dheid
Copy link
Contributor Author

dheid commented Feb 20, 2022

@jamietanna Ping

@dheid
Copy link
Contributor Author

dheid commented Feb 20, 2022

@daspilker I think it's a good thing to remove the old PostBuildScript stuff. It damages the configuration of the users.

@dheid
Copy link
Contributor Author

dheid commented Apr 29, 2022

@jamietanna Are you there?

@dheid
Copy link
Contributor Author

dheid commented Jun 8, 2022

@jamietanna How are you doing?

@jamietanna
Copy link
Contributor

Hey @dheid thanks for this, this looks like a reasonable change. Just to confirm, have you seen if the Dynamic DSL picks up all the options for the plugin that we'd want?

@dheid
Copy link
Contributor Author

dheid commented Jul 8, 2022

@jamietanna Yes, it includes everything

Copy link
Contributor

@jamietanna jamietanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, appreciate you doing this!

I'll get this released today + add an appropriate warning in the CHANGELOG

@jamietanna jamietanna merged commit d47672c into jenkinsci:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants