Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensible version strings #6

Closed
wozman opened this issue Feb 15, 2021 · 4 comments
Closed

Sensible version strings #6

wozman opened this issue Feb 15, 2021 · 4 comments

Comments

@wozman
Copy link

wozman commented Feb 15, 2021

Can we have version strings in line with the majority of other plugins, i.e major.minor.patch please?
We have an automated process to pull plugins to an internal on-prem repo and 0.11.2.8.82737cbfa6f5 has broken the version parser.

@jglick
Copy link
Member

jglick commented Feb 17, 2021

Fix your parser? https://jenkins.io/jep/229

@jglick jglick closed this as completed Feb 17, 2021
@wozman
Copy link
Author

wozman commented Feb 17, 2021

It's not my parser, it's a vendor product. Never mind, helpful as ever.

@jglick
Copy link
Member

jglick commented Feb 17, 2021

What vendor would this be? For some “repository”?

https://github.com/jenkinsci/lib-version-number/blob/6069936f093629bcf6e3a559dd67bb20a583d056/src/main/java/hudson/util/VersionNumber.java#L36-L53 FTR. There is no limit on the number of version number components, and nonnumeric final components are permitted. Also compliant with Maven (modulo jenkinsci/lib-version-number#6).

@wozman
Copy link
Author

wozman commented Feb 17, 2021

Yes understood. Unfortunately I work for a very large corporate and I'm not permitted to divulge any details. I'll raise it with the internal repo support team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants