Javadoc update required for guava upgrade #5647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
approved these changes
Jul 31, 2021
MarkEWaite
approved these changes
Jul 31, 2021
|
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. |
MarkEWaite
added
the
ready-for-merge
StefanSpieker
approved these changes
Jul 31, 2021
renjugokulam
pushed a commit
to shivagowda/jenkins
that referenced
this pull request
Aug 19, 2021
renjugokulam
added a commit
to shivagowda/jenkins
that referenced
this pull request
Aug 19, 2021
Javadoc update required for guava upgrade (jenkinsci#5647)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method was renamed to
advanceso the javadoc reference fails on newer versions, someone has re-styled the method at somepoint anyway fromforloop towhileso it's not even the sameDoc taken from guava javadoc that it was copied from
noticed in #5646