Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update access-modifier 1.22 → 1.24 #5642

Merged
merged 1 commit into from Jul 31, 2021
Merged

Conversation

jglick
Copy link
Member

@jglick jglick commented Jul 30, 2021

Supersedes #5640 + #5641. Picks up jenkinsci/lib-access-modifier#53 + jenkinsci/lib-access-modifier#54. Also see #5639.

Proposed changelog entries

N/A, developer only

Proposed upgrade guidelines

N/A

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@jglick jglick requested review from timja and basil July 30, 2021 18:19
@timja timja added skip-changelog Should not be shown in the changelog ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback labels Jul 30, 2021
@timja
Copy link
Member

timja commented Jul 30, 2021

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@timja timja merged commit 96cc91c into jenkinsci:master Jul 31, 2021
@jglick jglick deleted the access-modifier branch August 2, 2021 17:25
renjugokulam pushed a commit to shivagowda/jenkins that referenced this pull request Aug 19, 2021
renjugokulam added a commit to shivagowda/jenkins that referenced this pull request Aug 19, 2021
Update `access-modifier` 1.22 → 1.24 (jenkinsci#5642)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
4 participants