New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-65923] Accessibility issue - Images lacking "alt" text #5634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The status column also has no tooltip. Is that also a regression? |
@daniel-beck Do you mean this one?
It is. |
@benebsiny Yes, that. To clarify, that's also being addressed by your PR? |
@daniel-beck Yes |
timja
approved these changes
Jul 27, 2021
timja
approved these changes
Jul 27, 2021
timja
added
the
regression-fix
Pull request that fixes a regression in one of the previous Jenkins releases
label
Jul 27, 2021
basil
approved these changes
Jul 27, 2021
timja
added
the
ready-for-merge
The PR is ready to go, and it will be merged soon if there is no negative feedback
label
Jul 27, 2021
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
bmunozm
pushed a commit
to bmunozm/jenkins
that referenced
this pull request
Aug 10, 2021
…insci#5634) (cherry picked from commit 9bf8b33)
renjugokulam
pushed a commit
to shivagowda/jenkins
that referenced
this pull request
Aug 19, 2021
renjugokulam
added a commit
to shivagowda/jenkins
that referenced
this pull request
Aug 19, 2021
[JENKINS-65923] Accessibility issue - Images lacking "alt" text (jenkinsci#5634)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-for-merge
The PR is ready to go, and it will be merged soon if there is no negative feedback
regression-fix
Pull request that fixes a regression in one of the previous Jenkins releases
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-65923.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).