Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-65923] Accessibility issue - Images lacking "alt" text #5634

Merged
merged 1 commit into from Jul 29, 2021

Conversation

benebsiny
Copy link
Contributor

See JENKINS-65923.

Screenshot_20210725_183939

Proposed changelog entries

  • Show tooltips when users hover on the SVG icons

Proposed upgrade guidelines

N/A

Submitter checklist

  • (If applicable) Jira issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

@daniel-beck
Copy link
Member

The status column also has no tooltip. Is that also a regression?

@benebsiny
Copy link
Contributor Author

The status column also has no tooltip.

@daniel-beck Do you mean this one?
Screenshot_20210725_194039

Is that also a regression?

It is.

@daniel-beck
Copy link
Member

@benebsiny Yes, that. To clarify, that's also being addressed by your PR?

@benebsiny
Copy link
Contributor Author

@daniel-beck Yes

@daniel-beck daniel-beck self-requested a review July 26, 2021 09:46
@timja timja requested a review from a team July 27, 2021 19:05
@timja timja added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Jul 27, 2021
@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 27, 2021
@timja
Copy link
Member

timja commented Jul 27, 2021

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@timja timja merged commit 9bf8b33 into jenkinsci:master Jul 29, 2021
bmunozm pushed a commit to bmunozm/jenkins that referenced this pull request Aug 10, 2021
renjugokulam pushed a commit to shivagowda/jenkins that referenced this pull request Aug 19, 2021
renjugokulam added a commit to shivagowda/jenkins that referenced this pull request Aug 19, 2021
[JENKINS-65923] Accessibility issue - Images lacking "alt" text (jenkinsci#5634)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
4 participants