Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorter plugin label descriptions #5611

Merged
merged 1 commit into from Jul 31, 2021
Merged

Shorter plugin label descriptions #5611

merged 1 commit into from Jul 31, 2021

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Jul 5, 2021

Minor change - no changelog entries required.

Changes two label descriptions for plugins:

  • Agent Launchers and Controllers -- confusing given the new meaning of Controller => changed to Agent Management
  • Cluster Management and Distributed Build -- somewhat redundant (in properly setup Jenkins all builds are distributed...) => shortened to Cluster Management

Related to a proposal to use labels from Jenkins directly for the plugin site (jenkins-infra/plugin-site#754 )

daniel-beck
daniel-beck approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

(I have a larger patch locally somewhere overhauling this and adding a bunch of categories from what's used, if you plan to do more here I'd be happy to dig that up.)

@zbynek
Copy link
Contributor Author

zbynek commented Jul 12, 2021

@daniel-beck I don't have any more concrete ideas for improvement right now.

@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 30, 2021
@timja
Copy link
Member

timja commented Jul 30, 2021

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@timja timja added the skip-changelog Should not be shown in the changelog label Jul 30, 2021
@timja timja merged commit e223c2c into jenkinsci:master Jul 31, 2021
@zbynek zbynek deleted the patch-2 branch July 31, 2021 23:21
renjugokulam pushed a commit to shivagowda/jenkins that referenced this pull request Aug 19, 2021
@zbynek
Shorter plugin label descriptions (jenkinsci#5611)
ebcffe0
renjugokulam added a commit to shivagowda/jenkins that referenced this pull request Aug 19, 2021
@renjugokulam
Merge pull request #37 from shivagowda/shiv_2_e223c2c
110ff93 
Shorter plugin label descriptions (jenkinsci#5611)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-beck daniel-beck daniel-beck approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Milestone
No milestone
3 participants
@zbynek @timja @daniel-beck