Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Jersey 2 API plugin #115

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Use Jersey 2 API plugin #115

merged 1 commit into from
Jan 5, 2022

Conversation

basil
Copy link
Member

@basil basil commented Jan 5, 2022

#107 added jackson-jaxrs-json-provider, which exposed the need for the JAX-RS API. That was added in #111, which exposed the need for a JAX-RS implementation. Since a JAX-RS API and implementation are outside the scope of this plugin, I have created a new Jersey 2 API plugin providing the JAX-RS 2.1 API with Jersey 2 as its implementation. This PR adjusts the Jackson 2 API plugin to consume that new plugin as an optional dependency.

@basil basil requested a review from a team as a code owner January 5, 2022 18:49
@jtnord jtnord merged commit a8a9f3e into jenkinsci:master Jan 5, 2022
@basil basil deleted the jersey branch January 5, 2022 18:58
@jtnord
Copy link
Member

jtnord commented Jan 5, 2022

thanks basil. FWIW - if you want to enable CD on the jersey 2 plugin but keep the reasonable version numbering for the dependencies - this plugin is a good example of that.

@jtnord jtnord added chore dependencies Pull requests that update a dependency file labels Jan 5, 2022
@basil
Copy link
Member Author

basil commented Jan 5, 2022

@jtnord Can you please trigger a release to provide relief to users affected by JENKINS-67506? This was not done automatically, because you specified a label of chore, which is not considered an "interesting category" by the CD process.

@basil
Copy link
Member Author

basil commented Jan 5, 2022

@jtnord The release failed with

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.8.2:deploy (default-deploy) on project jackson2-api: Failed to deploy artifacts: Could not transfer artifact org.jenkins-ci.plugins:jackson2-api:hpi:2.13.1-246.va8a9f3eaf46a from/to maven.jenkins-ci.org (https://repo.jenkins-ci.org/releases/): authorization failed for https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/jackson2-api/2.13.1-246.va8a9f3eaf46a/jackson2-api-2.13.1-246.va8a9f3eaf46a.hpi, status: 403 Forbidden -> [Help 1]

This is a known issue described in the documentation. The recommendation is to

create an issue in the INFRA project on Jira, and let the team know in #jenkins-infra on Libera Chat.

@jtnord
Copy link
Member

jtnord commented Jan 5, 2022

@basil 388 https://github.com/jenkinsci/jackson2-api-plugin/runs/4719142311?check_suite_focus=true#step:4:161 passed and released. I accidentally ran the workflow twice so the second is likely a failure as the artiact already exists and the repo is setup to prevent redeployment. Can you download the artifact from artifactory? On my phone now so can not fully check, or have access to irc

@basil
Copy link
Member Author

basil commented Jan 5, 2022

Got it! Yes, looks like it got released at: https://github.com/jenkinsci/jackson2-api-plugin/releases/tag/2.13.1-246.va8a9f3eaf46a

@jtnord jtnord mentioned this pull request Apr 14, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore dependencies Pull requests that update a dependency file
Projects
None yet
2 participants