Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New changelist format in git-changelist-maven-extension 1.3 breaks PCT testing of core incrementals #28

Closed
basil opened this issue Jan 7, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@basil
Copy link
Member

basil commented Jan 7, 2022

Jenkins and plugins versions report

Jenkins: 2.329-rc31964.3b_29e9d46038 (from this build)
OS: Ubuntu 20.04.3 LTS x86_64

What Operating System are you using (both controller, and any agents involved in the problem)?

Ubuntu 20.04.3 LTS x86_64

Reproduction steps

Updating sample-plugin/pom.xml to

diff --git a/sample-plugin/pom.xml b/sample-plugin/pom.xml
index 396fceb..b996501 100644
--- a/sample-plugin/pom.xml
+++ b/sample-plugin/pom.xml
@@ -14,7 +14,7 @@
     <properties>
         <changelist>999999-SNAPSHOT</changelist>
         <bom>weekly</bom>
-        <jenkins.version>2.328</jenkins.version>
+        <jenkins.version>2.329-rc31964.3b_29e9d46038</jenkins.version>
         <java.level>8</java.level>
     </properties>
     <dependencyManagement>

try running e.g. PLUGINS=mailer TEST=jenkins.plugins.mailer.tasks.MimeMessageBuilderTest\#test_send bash local-test.sh.

Expected Results

The test passes.

Actual Results

The test fails with

Hook: org.jenkins.tools.test.hook.NodeCleanupBeforeCompileHook
Hook: org.jenkins.tools.test.hook.MultiParentCompileHook
Loaded multi-parent compile hook
Exception in thread "main" java.io.IOException: no jenkins-core.jar in /home/basil/src/jenkinsci/bom/target/local-test/megawar.war
        at org.jenkins.tools.test.PluginCompatTester.scanWAR(PluginCompatTester.java:872)
        at org.jenkins.tools.test.PluginCompatTester.testPlugins(PluginCompatTester.java:193)
        at org.jenkins.tools.test.PluginCompatTesterCli.main(PluginCompatTesterCli.java:175)

Anything else?

https://github.com/jenkinsci/plugin-compat-tester/blob/5a86f00cbbbba4e2c7dcb63f75538c8765e24e96/plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java#L126-L127 needs to be adjusted to match the new versioning scheme.

@jglick
Copy link
Member

jglick commented Jan 7, 2022

Do you want to propose a PR? I am guessing we just need to replace [0-9a-f.] with [0-9a-f._]?

@jglick
Copy link
Member

jglick commented Jan 7, 2022

Awkward because bom still relies on jenkinsci/plugin-compat-tester#276 which I never managed to get over the line (jenkinsci/bom#657).

@basil
Copy link
Member Author

basil commented Jan 19, 2022

which I never managed to get over the line

Well, in the immortal words of the great philosopher William Edward Hickson

If at first you don't succeed, try, try, try again.

@jglick
Copy link
Member

jglick commented Jan 19, 2022

Quick workaround would be a draft PR that merges the proposed fix for this with jenkinsci/plugin-compat-tester#276, just to get an incremental build.

@jglick
Copy link
Member

jglick commented Jan 27, 2022

Now tracked as jenkinsci/plugin-compat-tester#340.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants