Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting usage of proposed new infra.prepareToPublishIncrementals #13

Merged
merged 1 commit into from Sep 3, 2019

Conversation

jglick
Copy link
Member

@jglick jglick commented Aug 28, 2019

@jglick jglick requested a review from jeffret-b August 28, 2019 17:57
Copy link
Member

@jvz jvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds simple enough. No fancy declarative method? :P

Copy link
Contributor

@jeffret-b jeffret-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice and easy. I'll give it a try once the dependency is available.

@jglick
Copy link
Member Author

jglick commented Aug 28, 2019

No fancy declarative method?

In principle you could use this from inside a script block, and then add a special stage with agent none and another script block for the maybePublishIncrementals. I cannot imagine the result being easier to read or debug.

@jglick jglick merged commit 66607ac into jenkinsci:master Sep 3, 2019
@jglick jglick deleted the prepareToPublishIncrementals branch September 3, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants